Compatibility test may trigger segfaults #2098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip mongo on 1.6.2 Update test fixtures to remove deprecated versions and avoid lmdb due to segfault issues Init tests flow Update test workflow to specify test suite paths and change container image Add new trigger Update test workflow to provide default values for Python version, OS, and test suite Fix variable naming in test workflow for consistency with Python version Update test workflow to use fromJson for input parameters in matrix strategy Refactor test workflow to improve input handling and consistency for Python versions, OS, and test types dud Update input parameters in test workflow to use string type and provide default values for Python versions, OS, and test types dud dad Refactor test workflow to enhance input handling for Python versions, OS, and test suites Fix compat tests Update input handling in test workflow to parse OS and test suite parameters as JSON Fix container definition in test workflow for Windows compatibility Refactor test workflow to use inputs directly for Python versions, OS, and test suites test with actually building the code base Remove python version input from test workflow and set default to Python 3.11 Remove fetch-depth setting from test workflow Set ARCTICDB_BUILD_DIR based on OS in test workflow Add ARCTICDB_VCPKG_PACKAGES_DIR to workflow for package management Add Windows-specific steps for ccache removal and MSVC installation in CI workflow Add ARCTICDB_PYTEST_ARGS for customizable pytest arguments in CI Refactor pytest argument handling in parallel test script Refactor pytest argument handling in parallel test script to streamline argument processing
G-D-Petrov
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
G-D-Petrov
commented
Jan 6, 2025
| ] | ||
| return self.execute(python_commands, {"expected_df": df}) | ||
|
|
||
|
|
||
| @pytest.fixture( | ||
| scope="session", | ||
| # scope="session", |
There was a problem hiding this comment.
The changes here are so we can support parallel executions with pytest-xdist
G-D-Petrov
commented
Jan 6, 2025
| "lmdb", | ||
| # Don't include lmdb because there is a bug in 1.6.2/4.5.1 | ||
| # which causes the tests to segfault intermittently | ||
| # "lmdb", |
There was a problem hiding this comment.
This is the main changes, as :
- there is a bug on version 1.6.2 and 4.5.1 with lead to flaky seg faults with lmdb storage
- 1.6.2 doesn't support Mongo
G-D-Petrov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #1979
What does this implement or fix?
Removes the LMDB fixture from the compatibility tests because there is a bug on versions 1.6..2 and 4.5.1 that cause a Seg Fault with it.
Also adds a way to manually pass a string to pytest to change the tests that are executed.
Very useful in cases such as this change were you want to test only a specific subset of tests and you want to run them many times in parallel.
Any other comments?
Checklist
Checklist for code changes...