Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky resampling test #2090

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

vasil-pashov
Copy link
Collaborator

Reference Issues/PRs

What does this implement or fix?

The rules for generating offset and rule can generate huge numbers which are later converted to nanoseconds. The operations performed on the nanoseconds can overflow. This adds max_value limitation to the generators.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

The rules for generating offset and rule can generate huge numbers which are later converted to nanoseconds. The operations performed on the nanoseconds can overflow. This adds max_value limitation to the generators.
@vasil-pashov vasil-pashov merged commit 159d930 into master Dec 20, 2024
124 of 125 checks passed
@vasil-pashov vasil-pashov deleted the vasil.pashov/fix-flaky-resampling-test branch December 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants