Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 4897570890562900007: Fix decoding of fields with >2^16 blocks #2089

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bugfix 4897570890562900007: Fix decoding of fields with >2^16 blocks #2089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/arcticdb/storage/memory_layout.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,15 @@ enum class BitmapFormat : uint8_t {
// pointer to the first block
struct EncodedField {
EncodedFieldType type_ = EncodedFieldType::UNKNOWN;
uint16_t shapes_count_ = 0u;
uint16_t values_count_ = 0u;
uint32_t shapes_count_ = 0u;
uint32_t values_count_ = 0u;
uint32_t sparse_map_bytes_ = 0u;
uint32_t items_count_ = 0u;
BitmapFormat format_ = BitmapFormat::UNKNOWN;
std::array<Block, 1> blocks_;
};

static_assert(sizeof(EncodedField) == 60);
static_assert(sizeof(EncodedField) == 64);

enum class EncodingVersion : uint16_t {
V1 = 0,
Expand Down
Loading