Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new bi sample benchmark tests v2 (fromPR #1995) #2019

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

grusev
Copy link
Collaborator

@grusev grusev commented Nov 25, 2024

Reference Issues/PRs

From PR #1995 (all comments addressed)

Sample test benchmark for using one opensource BI CSV source.
The logic of a test is 
    - download if parquet file does not exists source in .bz2 format
    - convert it to parquet format
    - prepare library with it containing  several symbols that are constructed based on this DF
    - for each query we want to benchmark do a pre-check that this query produces SAME result on Pandas and arcticDB
    - run the benchmark tests

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@grusev grusev mentioned this pull request Nov 25, 2024
5 tasks
@grusev grusev changed the title new bi sample benchmark tests v2 (fromPR#1995) new bi sample benchmark tests v2 (fromPR #1995) Nov 25, 2024
@grusev grusev force-pushed the perf_first_bi_benchmark_v2 branch from 26c056f to 14c2cb3 Compare December 9, 2024 07:47
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these changes are in common.py? They're only used by bi_benchmarks.py, so should live in there, no?

@grusev grusev merged commit f6f0e5f into master Dec 9, 2024
140 of 141 checks passed
@grusev grusev deleted the perf_first_bi_benchmark_v2 branch December 9, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants