Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: Revert #1496 #1497

Merged
merged 1 commit into from
Apr 16, 2024
Merged

maint: Revert #1496 #1497

merged 1 commit into from
Apr 16, 2024

Conversation

jjerphan
Copy link
Collaborator

@jjerphan jjerphan commented Apr 15, 2024 •
edited
Loading

Reference Issues/PRs

This reverts commit 74f9932 after the publication of a new image containing CMake 3.29.2.

@jjerphan jjerphan marked this pull request as ready for review April 16, 2024 12:08
poodlewars
poodlewars approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@poodlewars poodlewars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that we should specify and pin a specific CMake across all platforms, but OK with merging this.

@jjerphan
Copy link
Collaborator Author

I still think that we should specify and pin a specific CMake across all platforms, but OK with merging this.

I agree, yet I do not know if this is possible without duplicating the installation of CMake.

@jjerphan jjerphan merged commit a2aa686 into master Apr 16, 2024
124 checks passed
@jjerphan jjerphan deleted the ci/revert-workaround-cmake-3.29.1-regressions branch April 16, 2024 14:12
grusev pushed a commit that referenced this pull request Nov 25, 2024
@jjerphan
maint: Revert #1496 (#1497)
77e5e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poodlewars poodlewars poodlewars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjerphan @poodlewars