Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-fix: Use cmake 3.29.2 with jwlawson/actions-setup-cmake@v2 #1496

Merged
merged 2 commits into from
Apr 15, 2024
Merged

hot-fix: Use cmake 3.29.2 with jwlawson/actions-setup-cmake@v2 #1496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9a477
ci: Try using cmake 3.29.2 from jwlawson/actions-setup-cmake@v2
jjerphan Apr 12, 2024
3d60d01
Fix syntax error
jjerphan Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/build_steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ jobs:
with:
submodules: recursive # Just in case a dep has its own third-party deps

# See: https://github.com/actions/runner-images/issues/9680#issuecomment-2051917949
- name: HOTFIX Setup CMake 3.29.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need to say HOTFIX do we? Choosing our own CMake seems sensible and not a hack.

Why are we only doing this on Windows? Using the CMake across all platforms might help to simplify the CI setup a bit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next image should come with this newer version of CMake, and I think this pin should rather be temporary as it duplicates installations of CMake.

I pinned for Windows because it was the only OS affected by the update of the image.

Nevertheless, the name of this step definitely can be changed.

Feel free to author changes on top of mine if you want to.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

Suggested change
- name: HOTFIX Setup CMake 3.29.2
- name: Setup CMake 3.29.2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as is.

if: matrix.os == 'windows'
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: '3.29.2'

- name: Configure sccache
uses: mozilla-actions/[email protected]
with:
Expand Down
Loading