Consistently handle timezones in QueryBuilder filtering
#1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexowens90
reviewed
Apr 9, 2024
alexowens90
approved these changes
Apr 9, 2024
IvoDD
force-pushed
the
fix-query-builder-timezone-issue
branch
from
b2e8712 to
b8106a6
Compare
- Follow up commit will fix the test
- This resolves the bug of not consistently handling timezones when writing and when filtering with query builder
IvoDD
force-pushed
the
fix-query-builder-timezone-issue
branch
from
b8106a6 to
7836e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
pd.TimestampAny other comments?
Checklist
Checklist for code changes...