-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build time #1474
Closed
Closed
Improve build time #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix compilation errors with clang-18 due to Werror - Run include-what-you-use to reduce includes and add forward declarations
vasil-pashov
force-pushed
the
maint/vasil.pashov/include-what-you-use
branch
2 times, most recently
from
April 3, 2024 13:30
6769e93
to
748df2b
Compare
vasil-pashov
force-pushed
the
maint/vasil.pashov/include-what-you-use
branch
from
April 3, 2024 13:47
748df2b
to
f65733d
Compare
IvoDD
reviewed
Apr 9, 2024
IvoDD
approved these changes
Apr 10, 2024
vasil-pashov
force-pushed
the
maint/vasil.pashov/include-what-you-use
branch
from
April 16, 2024 15:00
ad3665e
to
7aec972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Using the suggestions from include-what-you-use makes full builds ~10% faster sparing 20s on a local machine (Processor: 13th Gen Intel(R) Core(TM) i7-1370P, 1900 Mhz, 14 Core(s), 20 Logical Processor(s)) building with 20 threads.
Build info:
OS: Ubuntu (WSL)
Compiler: Clang 18
Linker: Mold
Build system: Ninja
(Clang and Mold are custom builds using additional flags -O3 -march=native -flto=full, arcticdb is built as usual)
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...