Fix SYMBOL_LIST Segment index out of bounds bug #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
force-pushed
the
fix-symbol-list-cache-out-of-bounds
branch
2 times, most recently
from
0ccbf28 to
2ea97a0
Compare
willdealtry
approved these changes
Apr 3, 2024
alexowens90
reviewed
Apr 3, 2024
The check `row < row_count()` in `string_at` was problematic for symbol list entries because they have the exception that it is possible for a column to have more rows than segment rows. That exception is because of the nature of the symbol list refactor in 4.2.0 which needed to remain backwards compatible with old readers. This change bypasses the check for symbol list entries and directly calls string_at or scalar_at of the Column.
IvoDD
force-pushed
the
fix-symbol-list-cache-out-of-bounds
branch
from
2ea97a0 to
d0ceb90
Compare
alexowens90
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check
row < row_count()instring_atwas problematic for symbol list entries because they have the exception that it is possible for a column to have more rows than segment rows.That exception is because of the nature of the symbol list refactor in 4.2.0 which needed to remain backwards compatible with old readers.
This change bypasses the check for symbol list entries and directly
calls string_at or scalar_at of the Column.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...