Bugfix/935/match pandas behviour when aggregating columns with nans #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
reviewed
Mar 21, 2024
| auto out_ptr = reinterpret_cast<RawType*>(col->ptr()); | ||
| for(auto i = 0u; i < unique_values; ++i, ++in_ptr, ++out_ptr) { | ||
| *out_ptr = in_ptr->value_; | ||
| for (auto it = column_data.begin<dynamic_schema_tdt>(); it != column_data.end<dynamic_schema_tdt>(); ++it, ++in_ptr) { |
There was a problem hiding this comment.
Don't hugely mind but snake case type is not the normal pattern. Is there a reason why this diverges?
There was a problem hiding this comment.
Nope, will change
DrNickClarke
approved these changes
Mar 21, 2024
| @@ -36,6 +36,29 @@ def test_group_on_float_column_with_nans(lmdb_version_store): | |||
| assert_frame_equal(expected, received) | |||
|
|
|||
|
|
|||
| # TODO: Add first and last once un-feature flagged | |||
| @pytest.mark.parametrize("aggregator", ("sum", "min", "max", "mean", "count")) | |||
| def test_aggregate_float_columns_with_nans(lmdb_version_store, aggregator): | |||
There was a problem hiding this comment.
The test looks correct to me
alexowens90
deleted the
bugfix/935/match-pandas-behviour-when-aggregating-columns-with-nans
branch
6 tasks
grusev
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935
Also addresses two of the bullet points from #1439: