-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #340: remove mmap buffer, require msgpack==0.5.0 #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunro
force-pushed
the
remove-mmap-buffer
branch
2 times, most recently
from
March 17, 2024 14:45
597a28f
to
c1928ce
Compare
DrNickClarke
approved these changes
Mar 18, 2024
jamesmunro
commented
Mar 18, 2024
jamesmunro
commented
Mar 18, 2024
alexowens90
requested changes
Mar 19, 2024
jamesmunro
force-pushed
the
remove-mmap-buffer
branch
from
March 25, 2024 09:34
b8c0a07
to
60e3988
Compare
…ct_types), consolidate msgpack usage into _msgpack_compact, add metadata size warning at 8MB (max is 16MB)
…eturned as strings from messages stored with early msgpack versions.
jamesmunro
force-pushed
the
remove-mmap-buffer
branch
from
March 31, 2024 09:34
8c8da59
to
7836ae0
Compare
alexowens90
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #340
What does this implement or fix?
We've been allocating a 4GB buffer for every data pack operation (not metadata).
There are a few issues with this,
This change also improves some other tightly coupled aspects of out msgpacking.
packb
so that we can store inuint64
column without extra copies, and removes bugs with original padding approach.list
andtuple
storage and requirestrict_types
. Previously we where relying on calls topackb
both whenstrict_types
argument wasn't available, and when thestrict_types
check failed, they where both caught byTypeError
.ArcticDbNotYetImplemented
when packed data is over 4GB, and instead letMemoryError
propagate frommsgpack
when it actually hits the limit (which is similar).Checklist
Checklist for code changes...