Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated docker image for arcticdb development #2081

Closed
G-D-Petrov opened this issue Dec 18, 2024 · 0 comments · Fixed by #2086
Closed

Create a dedicated docker image for arcticdb development #2081

G-D-Petrov opened this issue Dec 18, 2024 · 0 comments · Fixed by #2086
Assignees
@G-D-Petrov
Labels
enhancement New feature or request

Comments

@G-D-Petrov
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We are manually installing many dependencies on top of the manylinux image.

Describe the solution you'd like
We should create a dedicated docker image for dev with these dependencies.
This image should be published so it can be used by the various flows.
@G-D-Petrov G-D-Petrov added the enhancement New feature or request label Dec 18, 2024
@G-D-Petrov G-D-Petrov self-assigned this Dec 18, 2024
@G-D-Petrov G-D-Petrov mentioned this issue Dec 19, 2024
Merged
5 tasks
@G-D-Petrov G-D-Petrov linked a pull request Dec 19, 2024 that will close this issue
Create a dedicated docker image for ArcticDB development #2086
Merged
5 tasks
G-D-Petrov added a commit that referenced this issue Dec 23, 2024
@G-D-Petrov
Create a dedicated docker image for ArcticDB development (#2086)
6371256 
#### Reference Issues/PRs
#2081 

#### What does this implement or fix?
This PR aims to:
- create a docker image with the dev dependencies
- create a workflow to push it automatically to the github registry
- remove the use of the action that installs the dependencies manually
and use the new docker image

Successful manual run of the benchmark flow can be seen
[here](https://github.com/man-group/ArcticDB/actions/runs/12411871191).
It needed to be run manually because the changes to the workflow file
are not picked up correctly in the automatic run here.

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-D-Petrov G-D-Petrov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a dedicated docker image for ArcticDB development man-group/ArcticDB
1 participant
@G-D-Petrov