Skip to content

Commit

Permalink
Re comments on #1979 we skip the lmdb compat tests as well
Browse files Browse the repository at this point in the history
After we fix the segfaults we can re-enable
  • Loading branch information
IvoDD committed Nov 6, 2024
1 parent 58ef612 commit f24449b
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions python/tests/compat/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,12 @@ def arctic_uri(request):

@pytest.fixture()
def old_venv_and_arctic_uri(old_venv, arctic_uri):
# TODO: Once #1979 is understood and fixed reenable mongo, lmdb and azure for versions which have the fix.
if arctic_uri.startswith("mongo"):
# TODO: We tought the bug was fixed in 4.5.1 but it's still present.
pytest.skip("Mongo storage backend has a desctruction bug, which can cause flaky segfaults.")
if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("lmdb"):
pytest.skip("LMDB storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.")
pytest.skip("Mongo storage backend has a probable desctruction bug, which can cause flaky segfaults.")
if arctic_uri.startswith("lmdb"):
pytest.skip("LMDB storage backend has a probable desctruction bug, which can cause flaky segfaults.")
if arctic_uri.startswith("azure"):
# TODO: Once #1979 is understood and fixed reenable azure on versions which have the fix.
pytest.skip("Azure storage backend has probable a desctruction bug, which can cause flaky segfaults.")

return old_venv, arctic_uri

0 comments on commit f24449b

Please sign in to comment.