Skip to content

Commit

Permalink
Improvements based on PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Nick Clarke committed Apr 18, 2024
1 parent f0d6dd9 commit c66352b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions python/tests/unit/arcticdb/version_store/test_missing_empty.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,10 @@ def infer_type(s: pd.Series):
def fill_value(t):
fill_values = {
bool: False,
int: 0
int: 0,
np.int64: 0
}
if t in fill_values.keys():
if t in fill_values:
return fill_values[t]
return None

Expand All @@ -151,9 +152,8 @@ def pd_arcticdb_read_sim(df):
read_df = df.copy(True)
for c in df.columns:
t = infer_type(df[c])
print(c, t, fill_value(t))
if t and fill_value(t) is not None:
fv = fill_value(t)
fv = fill_value(t)
if fv is not None:
read_df[c] = df[c].fillna(fv)
return read_df

Expand Down

0 comments on commit c66352b

Please sign in to comment.