Skip to content

Commit

Permalink
Fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
phoebusm committed Mar 14, 2024
1 parent 3374477 commit a627d37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions python/arcticdb/adapters/s3_library_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ def __init__(self, uri: str, encoding_version: EncodingVersion, *args, **kwargs)

self._https = uri.startswith("s3s")
self._encoding_version = encoding_version
if platform.system() is not "Linux" and (self._query_params.CA_cert_path or self._query_params.CA_cert_dir):
if platform.system() != "Linux" and (self._query_params.CA_cert_path or self._query_params.CA_cert_dir):
raise ValueError("You have provided `ca_cert_path` or `ca_cert_dir` in the URI which is only supported on Linux. " \
"Remove the setting in the connection URI and use your operating system defaults.")
self._ca_cert_path = self._query_params.CA_cert_path
self._ca_cert_dir = self._query_params.CA_cert_dir
if not self._ca_cert_path and not self._ca_cert_dir and platform.system() is "Linux":
if not self._ca_cert_path and not self._ca_cert_dir and platform.system() == "Linux":
if ssl.get_default_verify_paths().cafile is not None:
self._ca_cert_path = ssl.get_default_verify_paths().cafile
if ssl.get_default_verify_paths().capath is not None:
Expand Down
2 changes: 1 addition & 1 deletion python/arcticdb/storage_fixtures/s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def __init__(self, factory: "BaseS3StorageFixtureFactory", bucket: str):
self.arctic_uri += f"&path_prefix={factory.default_prefix}"
if factory.ssl:
self.arctic_uri += "&ssl=True"
if platform.system() is "Linux":
if platform.system() == "Linux":
if factory.client_cert_file:
self.arctic_uri += f"&CA_cert_path={self.factory.client_cert_file}"
# client_cert_dir is skipped on purpose; It will be test manually in other tests
Expand Down

0 comments on commit a627d37

Please sign in to comment.