Skip to content

Commit

Permalink
Fix windows compilation errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Vasil Pashov committed Apr 16, 2024
1 parent 9b70d1f commit 530f056
Show file tree
Hide file tree
Showing 17 changed files with 50 additions and 30 deletions.
4 changes: 2 additions & 2 deletions cpp/arcticdb/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,9 @@ if(${TEST})
storage/test/test_storage_factory.cpp
storage/test/test_storage_exceptions.cpp
storage/test/test_azure_storage.cpp
stream/test/stream_test_common.hpp
stream/test/stream_test_common.cpp
stream/test/test_store_common.hpp
stream/test/test_aggregator.cpp
stream/test/test_append_map.cpp
stream/test/test_row_builder.cpp
Expand Down Expand Up @@ -915,9 +917,7 @@ if(${TEST})
PUBLIC
benchmark::benchmark
benchmark::benchmark_main
${COMMON_PUBLIC_TEST_LIBRARIES}
PRIVATE
${AWSSDK_LINK_LIBRARIES}
arcticdb_core_static
)

Expand Down
2 changes: 1 addition & 1 deletion cpp/arcticdb/codec/segment.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include "util/buffer.hpp"
#include <arcticdb/util/buffer.hpp>
#include <arcticdb/storage/common.hpp>
#include <google/protobuf/arena.h>
#include <arcticdb/entity/field_collection.hpp>
Expand Down
1 change: 1 addition & 0 deletions cpp/arcticdb/column_store/test/ingestion_stress_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <arcticdb/stream/aggregator.hpp>
#include <arcticdb/pipeline/query.hpp>
#include <arcticdb/stream/append_map.hpp>
#include <arcticdb/stream/test/test_store_common.hpp>

using namespace arcticdb;
namespace as = arcticdb::stream;
Expand Down
6 changes: 3 additions & 3 deletions cpp/arcticdb/entity/field_collection.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
#pragma once

#include <arcticdb/column_store/chunked_buffer.hpp>
#include <util/cursored_buffer.hpp>
#include <util/buffer.hpp>
#include <entity/types.hpp>
#include <arcticdb/util/cursored_buffer.hpp>
#include <arcticdb/util/buffer.hpp>
#include <arcticdb/entity/types.hpp>
#include <arcticdb/column_store/column_data.hpp>

namespace arcticdb {
Expand Down
2 changes: 1 addition & 1 deletion cpp/arcticdb/pipeline/frame_utils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include <arcticdb/python/python_to_tensor_frame.hpp>
#include <arcticdb/pipeline/string_pool_utils.hpp>
#include <arcticdb/util/offset_string.hpp>
#include <util/flatten_utils.hpp>
#include <arcticdb/util/flatten_utils.hpp>
#include <arcticdb/entity/timeseries_descriptor.hpp>
#include <arcticdb/entity/type_utils.hpp>

Expand Down
1 change: 0 additions & 1 deletion cpp/arcticdb/storage/storage.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <arcticdb/storage/key_segment_pair.hpp>
#include <arcticdb/storage/storage_options.hpp>
#include <arcticdb/util/composite.hpp>
#include <util/composite.hpp>

namespace arcticdb::storage {

Expand Down
4 changes: 2 additions & 2 deletions cpp/arcticdb/stream/test/stream_test_common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
* As of the Change Date specified in that file, in accordance with the Business Source License, use of this software will be governed by the Apache License, version 2.0.
*/

#include <arcticdb/stream/test/stream_test_common.hpp>
#include <arcticdb/entity/types.hpp>
#include <arcticdb/stream/piloted_clock.hpp>
namespace arcticdb {

std::atomic<timestamp> PilotedClock::time_{0};
std::atomic<entity::timestamp> PilotedClock::time_{0};

} //namespace arcticdb
16 changes: 0 additions & 16 deletions cpp/arcticdb/stream/test/stream_test_common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <arcticdb/version/version_store_api.hpp>
#include <arcticdb/stream/index.hpp>
#include <arcticdb/entity/protobufs.hpp>
#include <gtest/gtest.h>
#include <filesystem>

namespace fg = folly::gen;
Expand Down Expand Up @@ -336,19 +335,4 @@ inline auto test_store(const std::string &lib_name) {
return version_store;
}

struct TestStore : ::testing::Test {
protected:
virtual std::string get_name() = 0;

void SetUp() override {
test_store_ = test_store(get_name());
}

void TearDown() override {
test_store_->clear();
}

std::shared_ptr<arcticdb::version_store::PythonVersionStore> test_store_;
};

} //namespace arcticdb
26 changes: 26 additions & 0 deletions cpp/arcticdb/stream/test/test_store_common.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/* Copyright 2024 Man Group Operations Limited
*
* Use of this software is governed by the Business Source License 1.1 included in the file licenses/BSL.txt.
*
* As of the Change Date specified in that file, in accordance with the Business Source License, use of this software
* will be governed by the Apache License, version 2.0.
*/
#include <gtest/gtest.h>
#include <memory>

namespace arcticdb {
struct TestStore : ::testing::Test {
protected:
virtual std::string get_name() = 0;

void SetUp() override {
test_store_ = test_store(get_name());
}

void TearDown() override {
test_store_->clear();
}

std::shared_ptr<arcticdb::version_store::PythonVersionStore> test_store_;
};
}
4 changes: 2 additions & 2 deletions cpp/arcticdb/util/buffer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

#pragma once

#include <util/allocator.hpp>
#include <util/constructors.hpp>
#include <arcticdb/util/allocator.hpp>
#include <arcticdb/util/constructors.hpp>

#include <cstdint>
#include <memory>
Expand Down
2 changes: 1 addition & 1 deletion cpp/arcticdb/util/buffer_holder.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <column_store/column.hpp>
#include <arcticdb/column_store/column.hpp>
#include <vector>

namespace arcticdb {
Expand Down
2 changes: 1 addition & 1 deletion cpp/arcticdb/util/memory_tracing.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <array>
#include <fstream>
#include <arcticdb/util/preprocess.hpp>
#include <log/log.hpp>
#include <arcticdb/log/log.hpp>
#ifdef WIN32
#include <process.h>
#else
Expand Down
2 changes: 2 additions & 0 deletions cpp/arcticdb/version/test/test_merge.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <arcticdb/stream/aggregator.hpp>
#include <arcticdb/util/test/generators.hpp>
#include <arcticdb/stream/test/stream_test_common.hpp>
#include <arcticdb/stream/test/test_store_common.hpp>


struct MergeReadsTestStore : arcticdb::TestStore {
protected:
Expand Down
2 changes: 2 additions & 0 deletions cpp/arcticdb/version/test/test_sparse.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
#include <arcticdb/util/test/generators.hpp>
#include <arcticdb/stream/test/stream_test_common.hpp>
#include <arcticdb/python/python_to_tensor_frame.hpp>
#include <arcticdb/stream/test/test_store_common.hpp>


struct SparseTestStore : arcticdb::TestStore {
protected:
Expand Down
2 changes: 2 additions & 0 deletions cpp/arcticdb/version/test/test_version_map.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#include <arcticdb/util/configs_map.hpp>
#include <arcticdb/storage/test/in_memory_store.hpp>
#include <arcticdb/stream/test/stream_test_common.hpp>
#include <arcticdb/stream/test/test_store_common.hpp>


namespace arcticdb {

Expand Down
2 changes: 2 additions & 0 deletions cpp/arcticdb/version/test/test_version_map_batch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#include <arcticdb/stream/test/stream_test_common.hpp>
#include <arcticdb/util/test/gtest_utils.hpp>
#include <arcticdb/stream/piloted_clock.hpp>
#include <arcticdb/stream/test/test_store_common.hpp>


using namespace arcticdb;
using namespace arcticdb::pipelines;
Expand Down
2 changes: 2 additions & 0 deletions cpp/arcticdb/version/test/test_version_store.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#include <arcticdb/version/version_functions.hpp>
#include <arcticdb/pipeline/write_frame.hpp>
#include <arcticdb/stream/append_map.hpp>
#include <arcticdb/stream/test/test_store_common.hpp>


#include <chrono>
#include <thread>
Expand Down

0 comments on commit 530f056

Please sign in to comment.