Skip to content

Commit

Permalink
Add option to override the tag used by the flows
Browse files Browse the repository at this point in the history
  • Loading branch information
G-D-Petrov committed Dec 19, 2024
1 parent cb303ce commit 26d4de6
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/analysis_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
run_all_benchmarks:
type: boolean
default: false
dev_image_tag:
description: Tag of the ArcticCB development image to use for benchmark and code coverage flows
type: string
default: latest

schedule: # Schedule the job to run at 12 a.m. daily
- cron: '0 0 * * *'
Expand Down Expand Up @@ -45,6 +49,7 @@ jobs:
commit: ${{ matrix.commits }}
run_all_benchmarks: ${{ inputs.run_all_benchmarks || false }}
run_on_pr_head: ${{ github.event_name == 'pull_request_target' }}
dev_image_tag: ${{ inputs.dev_image_tag }}

publish_benchmark_results_to_gh_pages:
name: Publish benchmark results to gh-pages
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/benchmark_commits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
run_all_benchmarks: {required: true, type: boolean, description: Run all benchmarks or just the one for the given commit}
commit: {required: true, type: string, description: commit hash that will be benchmarked}
run_on_pr_head: {required: false, default: false, type: boolean, description: Specifies if the benchmark should run on PR head branch}
dev_image_tag: {required: false, default: 'latest', type: string, description: Tag of the ArcticDB development image}
jobs:
start_ec2_runner:
uses: ./.github/workflows/ec2_runner_jobs.yml
Expand All @@ -19,7 +20,7 @@ jobs:
always() &&
!cancelled()
runs-on: ${{ needs.start_ec2_runner.outputs.label }}
container: ghcr.io/man-group/arcticdb-dev:latest
container: ghcr.io/man-group/arcticdb-dev:${{ inputs.dev_image_tag }}
env:
# this is potentially overflowing the cache, so should be looked into after we address issue #1057
SCCACHE_GHA_VERSION: ${{vars.SCCACHE_GHA_VERSION || 1}} # Setting this env var enables the caching
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ on:
description: Override CMAKE preset type
type: choice
options: ["-", debug, release]
dev_image_tag:
description: Tag of the ArcticCB development image to use for the Linux C++ tests build
type: string
default: latest
run-name: Building ${{github.ref_name}} on ${{github.event_name}} by ${{github.actor}}
concurrency:
group: ${{github.ref}}
Expand Down Expand Up @@ -52,7 +56,7 @@ jobs:
mongodb:
image: "mongo:4.4"
container:
image: ghcr.io/man-group/arcticdb-dev:latest
image: ghcr.io/man-group/arcticdb-dev:${{inputs.dev_image_tag}}
volumes:
- /:/mnt
windows_matrix:
Expand Down

0 comments on commit 26d4de6

Please sign in to comment.