Fix date parsing for kingston.gov.uk. Fixes #3224 #3225
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplex and parse yearless date strings
cmsj
changed the title
5ila5
reviewed
Dec 18, 2024
| now = datetime.now() | ||
| date = datetime.strptime(date_string + f" {now.year}", "%A %d %B %Y") | ||
|
|
||
| if date < now: |
There was a problem hiding this comment.
This is also true for collections on the current date so they will be moved to the next year. You could resolve this by converting now and date from datetime objects to date objects before this instead of at the end of the function.
|
You could also use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date parsing is now in its own function because it has grown in complexity. Kingston has stopped including years in their dates, so we have to add them manually and account for year boundaries.