Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Insert-IT as a service provider #1717

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Conversation

derDeno
Copy link
Contributor

@derDeno derDeno commented Jan 24, 2024

Added Insert-IT as a new service provider.

This provides a streamlined way for all Insert-IT based apps to be integrated.

Note: The benefit of this integration is the easy configuration, as it could be used with a location ID, which needs to be extracted from an url, or by simply providing street name and house number. Therefore it is easier to integrate than using static ics files.

Currently these municipalities are supported:

  • Hattingen, DE
  • Herne, DE
  • Kassel, DE
  • Krefeld, DE
  • Mannheim, DE
  • Offenbach, DE

Breaking Change

This replaces the offenbach_de source and fixes the broken mannheim source.

Testing

Test where done successfully:

Testing source insert_it_de ...
  found 136 entries for Offenbach Address
  found 136 entries for Offenbach Location ID
  found 136 entries for Mannheim Address
  found 136 entries for Mannheim Location ID

Misc

Two broken docs where also fixed (missing .md):

  • lund_se.md
  • stoke_gov_uk.md

Added Insert IT as a source for all Insert IT based Apps. Therefore deleted Offenbach. Mannheim moved also to Insert IT from Abfall+.

Also added:
- Hattingen
- Herne
- Kassel
- Krefeld
@5ila5
Copy link
Collaborator

5ila5 commented Jan 25, 2024

you forgot to add https://insert-it.de/BMSAbfallkalenderLuebeck
I would keep Offenbach for now to not break existing configurations you could just inherit from the Insert-IT source and add a logger warning to wswitch to the other source:

from waste_collection_schedule.souce.insert_it_de import Source as InesrtItSource

class Source(InesrtItSource):
    def __init__(self, f_id_location):
         super().__init__("Offenbach", location_id=f_id_location)

doc/source/insert_it_de.md Outdated Show resolved Hide resolved
doc/source/insert_it_de.md Show resolved Hide resolved
@derDeno
Copy link
Contributor Author

derDeno commented Jan 25, 2024

requested changes were done

@5ila5 5ila5 merged commit 07e644c into mampfes:master Jan 26, 2024
1 check passed
@5ila5
Copy link
Collaborator

5ila5 commented Jan 26, 2024

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants