-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Insert-IT as a service provider #1717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Insert IT as a source for all Insert IT based Apps. Therefore deleted Offenbach. Mannheim moved also to Insert IT from Abfall+. Also added: - Hattingen - Herne - Kassel - Krefeld
you forgot to add https://insert-it.de/BMSAbfallkalenderLuebeck from waste_collection_schedule.souce.insert_it_de import Source as InesrtItSource
class Source(InesrtItSource):
def __init__(self, f_id_location):
super().__init__("Offenbach", location_id=f_id_location) |
5ila5
requested changes
Jan 25, 2024
requested changes were done |
5ila5
approved these changes
Jan 26, 2024
Thanks for your contribution |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Insert-IT as a new service provider.
This provides a streamlined way for all Insert-IT based apps to be integrated.
Note: The benefit of this integration is the easy configuration, as it could be used with a location ID, which needs to be extracted from an url, or by simply providing street name and house number. Therefore it is easier to integrate than using static ics files.
Currently these municipalities are supported:
Breaking Change
This replaces the offenbach_de source and fixes the broken mannheim source.
Testing
Test where done successfully:
Misc
Two broken docs where also fixed (missing .md):