Hide libcurl internally instead of wrapping #168
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #159
TODO:
Two points still need to be handled (maybe after completing powerloader integration in mamba? - mostly for the first one):
ssl_backend_t
enum conversion to use outside powerloader.progress_callback_t = std::function<int(curl_off_t, curl_off_t)>
indownload_target.hpp
is apparently used in mamba withstd::size_t
instead ofcurl_off_t
. So I don't see whycurl_off_t
is used here.If there is no specific reason, it should directly use
std::size_t
.