fixed: incorrect erasing of env vars #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klaim
force-pushed
the
klaim/remove-erase
branch
from
a59a741
to
6d5977e
Compare
mathbunnyru
reviewed
Nov 20, 2024
| conda_environment_env_vars.begin(), | ||
| conda_environment_env_vars.end(), | ||
| [](auto& el) { return el.second == CONDA_ENV_VARS_UNSET_VAR; } | ||
| conda_environment_env_vars.erase( |
There was a problem hiding this comment.
Maybe leave a comment about using std::erase_if when we switch to C++20?
JohanMabille
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expectaction of this change is that the intent was to remove elements (env vars values) from that vector, in which case an
erasewas missing asremove_ifwill not remove elements, just move them around and report where the new range ends (c++20'sstd::erase_ifwould have done the job more properly here - or replacing the container by a flat_map).