Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix x86_64 to use underscore instead of dash #3404

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

traversaro
Copy link
Member

See #3222 (comment) .

Fix #3222 .

@traversaro traversaro changed the title Fix x86_64 to use underscore instead of dash [1.x] Fix x86_64 to use underscore instead of dash Aug 12, 2024
@JohanMabille
Copy link
Member

Thanks for tackling this. Can you rebase on latest 1.x? This should fix the CI.

@traversaro
Copy link
Member Author

Thanks for tackling this. Can you rebase on latest 1.x? This should fix the CI.

Done!

@Hind-M Hind-M merged commit 6520c5b into mamba-org:1.x Sep 6, 2024
17 checks passed
@traversaro
Copy link
Member Author

Great, thanks! How does it work for forward porting this to main/2.* ?

@Hind-M
Copy link
Member

Hind-M commented Sep 6, 2024

Great, thanks! How does it work for forward porting this to main/2.* ?

You can open a PR against main to do the same :) (and mention that it's forward porting this PR).

@traversaro
Copy link
Member Author

Great, thanks! How does it work for forward porting this to main/2.* ?

You can open a PR against main to do the same :) (and mention that it's forward porting this PR).

Great, that is easy. : )

Done in #3433 .

@matthewfeickert
Copy link

👋 @JohanMabille @Hind-M Would it be possible to get a v1.5.10 patch release in the next week with this fix in it? This would unblock all the x86 microarch level packages on conda-forge, which currently can't be installed with mamba or micromamba (c.f. conda-forge/microarch-level-feedstock#10). I appreciate though that this might not be something that's in the immediate roadmap. Thank you for maintaining this infrastructure for everyone!

@Hind-M
Copy link
Member

Hind-M commented Sep 23, 2024

Hey @matthewfeickert, 1.5.10 is available now!

@matthewfeickert
Copy link

matthewfeickert commented Sep 24, 2024

Amazing. Thank you very much @Hind-M (as well as @traversaro for the fix)! 🚀

(I've confirmed things are working now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants