Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows path manipulation and other cleanups #2801

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Windows path manipulation and other cleanups #2801

merged 5 commits into from
Aug 31, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Aug 31, 2023 •
edited
Loading

  • Add path_win_to_posix
  • Add path_to_posix
  • Move path functions from url_manip to path_manip
  • Refactor is_path > is_explicit_path to not use regex
  • Isolate build time os detection into mamba/util/build.hpp

@AntoinePrv AntoinePrv changed the title Windows path manipulation Windows path manipulation and other cleanups Aug 31, 2023
@AntoinePrv AntoinePrv self-assigned this Aug 31, 2023
@AntoinePrv AntoinePrv mentioned this pull request Aug 31, 2023
Merged
@JohanMabille JohanMabille merged commit 3fcff39 into mamba-org:main Aug 31, 2023
23 checks passed
@AntoinePrv AntoinePrv deleted the path-win-posix branch September 1, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees

@AntoinePrv AntoinePrv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoinePrv @JohanMabille