Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Julien Jerphanion <[email protected]>
  • Loading branch information
henryiii and jjerphan authored Nov 21, 2024
1 parent 8332729 commit 74879e8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/brew.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Brew tests impl
name: Homebrew and Linuxbrew toolchains

on:
workflow_call:
Expand All @@ -18,13 +18,13 @@ jobs:
- name: Correct the creation permissions
run: sudo chown -R linuxbrew .

- name: Install prerequisites
- name: Install host and build dependencies
run: brew install fmt libarchive libsolv lz4 openssl@3 reproc simdjson xz yaml-cpp zstd cmake cli11 nlohmann-json spdlog tl-expected curl pkgconfig python bzip2 krb5 zlib

- name: Configure
- name: Configure to build mamba
run: cmake -S. -Bbuild -DBUILD_LIBMAMBA=ON -DBUILD_MAMBA=ON -DBUILD_SHARED=ON -DBUILD_STATIC=OFF

- name: Build
- name: Build mamba
run: cmake --build build -j4

build_homebrew:
Expand All @@ -35,13 +35,13 @@ jobs:
- name: Checkout mamba repository
uses: actions/checkout@v4

- name: Install prerequisites
- name: Install host and build dependencies
run: brew install fmt libarchive libsolv lz4 openssl@3 reproc simdjson xz yaml-cpp zstd cmake cli11 nlohmann-json spdlog tl-expected pkgconfig python

- name: Configure
- name: Configure to build mamba
run: >
cmake -S. -Bbuild -DBUILD_LIBMAMBA=ON -DBUILD_MAMBA=ON -DBUILD_SHARED=ON -DBUILD_STATIC=OFF
-DLibArchive_ROOT=$(brew --prefix libarchive)
- name: Build
- name: Build mamba
run: cmake --build build -j4
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ jobs:
build_type: ${{ matrix.build_type }}

brew_tests:
name: Brew
name: Homebrew and Linuxbrew toolchains
uses: ./.github/workflows/brew.yml

0 comments on commit 74879e8

Please sign in to comment.