SHE Improvement Proposals (SHEiPs)

SHE Improvement Proposals (SHEiPs) are standards for improving the Shenanigan platform, including core development updates, community organization, design standards, DAO operations, and written documentation. As a result, SHEiPs empower SHE to mature as an open source project and community. This process was initially defined in SHEiP-1.

Want to explore merged SHEiPs? View the index of all merged SHEiPs.

Contributing

1. Propose a new idea

Ideas are incomplete proposals meant to initiate community conversation.

Create a new issue in the SHEiP repository containing the idea for your your proposal, following the SHEiP template format. Be sure to add the Status: IDEA label to your issue.

2. Complete your draft

Drafts are complete proposals, but still undergoing rapid iteration and change.

Complete your proposal by filling out all appropriate fields in the SHEiP template. Update your proposal to Status: DRAFT in the issue header and Github label. Gather community feedback and make improvements as required.

3. Enter last call for community feedback

Last Calls are stable proposals ready for final review by the community.

Once you feel that your proposal is stable and ready for final review by the community, update your proposal to Status: LAST CALL in the issue header and Github label. In order to proceed beyond Last Call, your issue must remain in Last Call for at least 2 weeks and any technical changes that are requested must be addressed by the author.

4. Submit a Pull Request

Pull Requests are SHEiPs ready for consideration by editors and/or core developers.

When your proposal exits Last Call, you should submit a Pull Request to the SHEiP repository. To do this, fork the SHEiP repository by clicking "Fork" in the top right. Add your SHEiP to your fork of the repository. Update your proposal to Status: PENDING in the issue header and Github label (on both your previous open issue and new PR). Then, submit a Pull Request to the SHEiP repository.

Upon submission an editor will manually review the first PR for a new SHEiP, assign it a canonical number (i.e. SHEiP-1), and merge it into the SHEiP repo. They will then reach out to discuss next steps to achieve finalization. These steps will depend on whether or not your SHEiP is of type Core.

When submitting your Pull Request:

• Images: If your SHEiP requires images, the image files should be included in a subdirectory of your SHEiP folder as follows: SHEiP-N/assets (where N is to be replaced with the SHEiP number). When linking to an image in the SHEiP, use relative links such as ./assets/image.png.

• Tables: If your SHEiP requires csv tables, the table csv files should be included in a subdirectory of your SHEiP folder as follows: SHEiP-N/tables (where N is to be replaced with the SHEiP number). When linking to a table in the SHEiP, use relative links such as ./tables/table.csv.

5. Get your SHEiP finalized

Finalized SHEiPs are SHEiPs that are have been approved.

5a. If your SHEiP is an Improvement SHEiP

An editor will reach out to provide the dates of the upcoming Shenanigan Weekly Huddles. Once you select one, your issue will be added to the agenda for that huddle where it will be discussed to take it to a community vote.

After the huddle, a team member will create a new snapshot vote with the aforementioned SHEiP. The vote will last 3-5 days and will signal the community to vote on the preferred outcome.

Once the vote is finalized, SHEiP editors will update your SHEiP to Status: ACCEPTED. Once your proposal has been implemented into the SHE product, SHEiP editors will update your SHEiP to Status: FINAL.

5b. If your SHEiP is a non-Improvement SHEiP

An editor will ask if anyone objects to it being finalized. If not, the SHEiP will go to snapshot and if the community does not vote for it to pass - for instance, because contributors point out significant issues with the SHEiP - they may close the PR and request that you fix the issues in the draft before trying again. If the editor finds there is rough consensus, they will merge the PR and update it to Status: FINAL.

SHEiP Terms

Categories

• Improvement: a SHEiP that affects the product or community.
• Meta: a SHEiP that affects the governance process for SHEiPs.
• Informational: a SHEiP that is merely for informational purposes but requires no action by the community, and will not be merged as a SHEiP.

Types

Only applicable to SHEiPs of type Standards.

• Development: a SHEiP that affects code or codebase improvements.
• Design: a SHEiP that affects the way SHE interacts with its members.
• Operations: a SHEiP that affects DAO processes or conventions .
• Documentation: a SHEiP that affects the written word of SHE

Statuses

• Idea: an SHEiP issue that is incomplete.
• Draft: an SHEiP issue that is undergoing rapid iteration and changes.
• Last Call: an SHEiP issue that is stable and ready for final review by the community.
• Pending: an SHEiP that has been merged but not finalized.
• Accepted (Core): an SHEiP of type Core that has been accepted by the core devs to be included in a future network upgrade.
• Final (Core): an SHEiP of type Core that has already been released in a network upgrade.
• Final (non-Core): a non-core SHEiP that has met all criteria and is finished.

Editors

• Victor (@youngkidwarrior)