Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark #27

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Mark #27

wants to merge 35 commits into from

Conversation

markwitt1
Copy link
Contributor

No description provided.

@markwitt1
Setup prettier ✨
902764a
@markwitt1
Ran npm run format:fix
b4b6a5c
@markwitt1
Enable formatOnSave
1093f7d
@markwitt1
Remove redundant metadata (check https://nextjs.org/docs/app/building…
2f4fff6 
…-your-application/optimizing/metadata#ordering)
@markwitt1
Redesign content.ts to be single source of truth
69169f0
@markwitt1
Proposal: Refactor App to completely abstract away content from UI co…
dbd5530 
…de, using nested routing. Improve exercise component to support single-and multi-answer questions.
@markwitt1
Add @typescript-eslint/recommended for better linting such as no-unus…
34f5adb 
…ed-vars
@markwitt1
Redo Sidebar using ShadCN accordion. Improve Routing. Refactor quiz c…
0c98c4f 
…omponent
@markwitt1
randomize question options
bf3b68f
@markwitt1
Add ESLint rule to only warn about unused variables instead of errori…
55ed4fc 
…ng out
@markwitt1
Update NavBar to get chapters from props
57b1d37
@markwitt1
Adjust Question component to support quiz mode + implement quiz mode
aa40a94
@markwitt1
Adopt StartScreen and EndScreen for quiz
e936fc9
@markwitt1
Cleanup unused files
3e8f2dd
@markwitt1
Implement Retry Feature
10e4628
@markwitt1
Install Posthog (https://eu.posthog.com/project/20336/onboarding/prod…
d74f975 
…uct_analytics?step=install) Please add `NEXT_PUBLIC_POSTHOG_KEY` and `NEXT_PUBLIC_POSTHOG_HOST` to .env.local
@markwitt1
Add PostHog event tracking to quiz and chapter pages
471e718
@markwitt1
Add prettier-plugin-tailwindcsshttps://tailwindcss.com/blog/automat…
565e9f2 
…ic-class-sorting-with-prettier
@markwitt1
Ran npx prettier --write .
7892cb0
@markwitt1
Fix svg rules
3dcce1e
@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024

@markwitt1 is attempting to deploy a commit to the Malik Piara's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
logicola ❌ Failed (Inspect) May 4, 2024 11:50am

@malikpiara
Copy link
Owner

It seems like the deployment failed almost by the end due to ESlint:

image

@malikpiara
Copy link
Owner

@markwitt1 the deployment failed again but it seems like we're almost there!

image

@malikpiara
Copy link
Owner

The deployment worked @markwitt1!! Tomorrow (Monday) I'll test and share my feedback!

@malikpiara malikpiara self-requested a review May 4, 2024 12:21
@malikpiara
Copy link
Owner

Hi @markwitt1, thank you for the valuable contributions! Since some changes break the usability or are not part of the core of the product, I started cherry-picking commits so your work can be officially recognised and visible to everyone!

malikpiara
malikpiara reviewed May 4, 2024
View reviewed changes
app/basic-propositional-logic/page.tsx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @markwitt1, can you explain these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malikpiara malikpiara malikpiara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markwitt1 @malikpiara