[WIP] New Store implementation using Redis #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Store` class is a redis version of `CircuitSwitch::CircuitSwitch`. Redis lets us store a hash with key, so it converts itself into a Hash and stores it into redis. It tries to have the same interface as `CS::CS` so that it's easy to make transition.
New redis gem requires Ruby 2.4 and above. After all, it's too old :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10
This new
Storeclass is a substitution forCircuitSwitch::CircuitSwitchwhich might cause deadlock.I'll modify Engine to use Store as well but it'll take some time (using
form_withis somewhat difficult).