Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircuitSwitch might cause too many Deadlock #10

Open
makicamel opened this issue Dec 8, 2021 · 1 comment · May be fixed by #12
Open

CircuitSwitch might cause too many Deadlock #10

makicamel opened this issue Dec 8, 2021 · 1 comment · May be fixed by #12

Comments

@makicamel
Copy link
Owner

CircuitSwitch.run and CircuitSwitch.report increment run_count and report_count when they are called.
If many method calls pour into, CircuitSwitch tries writing to the single record frequently.
This might cause too many Deadlock and increase cpu load.

I have 2 plans.

  1. Add apis not to increment count.
  2. Rewrite gem, modify data store to Redis.
@okuramasafumi
Copy link
Contributor

https://github.com/rails/kredis
Rails now provides kredis which might make it easier to use Redis instead of RDB.

@okuramasafumi okuramasafumi linked a pull request Apr 16, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] New Store implementation using Redis okuramasafumi/circuit_switch
2 participants
@okuramasafumi @makicamel