Assign nil to @index when fail to find suitable file to be patched

makicamel · Oct 8, 2023 · 4f1e814 · 4f1e814
1 parent b882c91
commit 4f1e814
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/bulletmark_repairer/associations_builder.rb b/lib/bulletmark_repairer/associations_builder.rb
@@ -6,7 +6,7 @@ module BulletmarkRepairer
   class AssociationsBuilder
     def build(marker)
       # TODO: Notify if fail to find suitable file to be patched
-      return if marker.index == ':' # viz marker.index is blank
+      return unless marker.index
 
       if associations[marker.index]
         associations[marker.index].add(marker)

diff --git a/lib/bulletmark_repairer/markers.rb b/lib/bulletmark_repairer/markers.rb
@@ -71,7 +71,7 @@ def set_up
             @instance_variable_name = line&.scan(/\b?(@[\w]+)\b?/)&.flatten&.last
           end
         end
-        @index = view_yield_index.negative? ? ':' : "#{view_file}:#{view_yield_index}"
+        @index = view_yield_index.negative? ? nil : "#{view_file}:#{view_yield_index}"
       else
         # TODO: Ignore controllers list
         # TODO: Allow directories list
@@ -90,7 +90,7 @@ def set_up
             break if line.match?(/^\s+def [()\w\s=]+$/)
           end
         end
-        @index = @instance_variable_name ? "#{@file_name}:#{controller_yield_index}" : ':'
+        @index = @instance_variable_name ? "#{@file_name}:#{controller_yield_index}" : nil
       end
     end
   end