Basic RPS program - JM #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanzAkor
reviewed
Jul 11, 2022
| erb(:result) | ||
| end | ||
|
|
||
| def pick_winner(player, opponent) |
There was a problem hiding this comment.
Nested if statement could be optimised better. Maybe use a hash.
Also, put this in a class file and instantiate in the app file to keep it more tidy.
| scenario "When I select 'Rock', I will lose if the machine selects 'Paper'" do | ||
| allow_any_instance_of(@opponent_choice).to receive(:sample).and_return(:paper) | ||
| visit '/' | ||
| fill_in('name', with: 'Jordan') |
There was a problem hiding this comment.
Add a web_helpers page where you can create a separate method and call it here, to keep the test more tidy and avoid repeating too many lines.
|
|
||
| <h2>You picked <%= @user_choice %>, and your opponent picked <%= @opponent_choice %></h2> | ||
|
|
||
| <form action="/" method="get"> |
There was a problem hiding this comment.
Redirect to the game and keep the user's name so that they don't need to keep entering it again.
Enabling sessions will help with this:
https://github.com/makersacademy/course/blob/main/apprenticeships_intro_to_the_web/walkthroughs/post_redirect_get_pattern.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Rock, Paper, Scissors program - quite limited testing, but it works properly!