Test to Home page #251
Test to Home page #251
Conversation
| erb :index | ||
| end | ||
|
|
||
| post '/names' do |
There was a problem hiding this comment.
Indentation isn't in line with rest of code
| @@ -0,0 +1,16 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
HTML structure isn't required for ERB files to work
|
|
||
| post '/names' do | ||
| session[:player_name] = params[:player_name] | ||
| redirect '/play' |
There was a problem hiding this comment.
Could this be done without /names? Maybe in /play instead to save having to redirect the user?
| <p>Make your selection: Rock, Paper or Scissors</p> | ||
|
|
||
| <form action="/result" method="get" class="rps"> | ||
| <input type="submit" value="Rock"> |
There was a problem hiding this comment.
Maybe a button might be more helpful - "Input" does take a value but it might be more useful. Button requires a name, which can then be accessed by app.rb
| end | ||
|
|
||
| get '/result' do | ||
| @player_name = session[:player_name] |
| end | ||
|
|
||
| get '/result' do | ||
| @player_name = session[:player_name] | ||
| erb :result |
There was a problem hiding this comment.
Before this, you should access the button/input value from the user (rock, paper or scissors).
You could then sample the three choices for the computer, and work out a result before returning to the Result page.
| </head> | ||
| <body> | ||
| <%= @player_name %>, the results are in! | ||
|
|
Made a small change