Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executive doc 2024-02-07 #2549

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Executive doc 2024-02-07 #2549

merged 3 commits into from
Feb 5, 2024

Conversation

0xldr
Copy link
Collaborator

@0xldr 0xldr commented Feb 2, 2024

No description provided.

@0xldr 0xldr added Executive relates to an executive vote Draft PR is still being worked on labels Feb 2, 2024
@0xldr 0xldr changed the title create exec doc Executive doc 2024-02-07 Feb 2, 2024
@0xldr 0xldr marked this pull request as ready for review February 2, 2024 17:22
@0xldr 0xldr removed the Draft PR is still being worked on label Feb 2, 2024
MakerJanSky
MakerJanSky requested changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, ldr.

governance/votes/Executive vote - February 07, 2024.md Outdated Show resolved Hide resolved
governance/votes/Executive vote - February 07, 2024.md Outdated Show resolved Hide resolved
governance/votes/Executive vote - February 07, 2024.md Outdated Show resolved Hide resolved
governance/votes/Executive vote - February 07, 2024.md Outdated Show resolved Hide resolved
governance/votes/Executive vote - February 07, 2024.md Show resolved Hide resolved
governance/votes/Executive vote - February 07, 2024.md Show resolved Hide resolved
MakerJanSky
MakerJanSky approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, ldr.

@0xldr
Copy link
Collaborator Author

0xldr commented Feb 5, 2024

Disregard failing check, there is a bug in the script. Checked manually against https://vote.makerdao.com/executive/create

Good to merge.

@0xldr 0xldr merged commit 093907a into makerdao:master Feb 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakerJanSky MakerJanSky MakerJanSky approved these changes

Assignees
No one assigned
Labels
Executive relates to an executive vote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xldr @MakerJanSky