We only wait for <iframe> elements with a [src] attribute

makandra · Jun 21, 2024 · 2ec2a86 · 2ec2a86
1 parent 5281165
commit 2ec2a86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 
 # Unreleased
 
-- We no longer wait for `<script>` elements that do not load JavaScript
+- We now only wait for `<script>` elements with a JavaScript type
+- We only wait for `<iframe>` elements with a `[src]` attribute
 
 
 # 2.2.1

diff --git a/lib/capybara-lockstep/helper.js b/lib/capybara-lockstep/helper.js
@@ -188,7 +188,7 @@ window.CapybaraLockstep = (function() {
   }
 
   function isTrackableIFrame(element) {
-    return element.matches('iframe') &&
+    return element.matches('iframe[src]') &&
       !hasDataSource(element) &&
       element.getAttribute('loading') !== 'lazy'
   }