OSSM-8235 fix broken httpbin samples #1064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanlin Xu <[email protected]>
eoinfennessy
reviewed
Nov 5, 2024
| imagePullPolicy: IfNotPresent | ||
| name: httpbin | ||
| ports: | ||
| - containerPort: 8001 | ||
| command: ["gunicorn", "-b", "0.0.0.0:8001", "httpbin:app", "-k", "gevent"] | ||
| - containerPort: 8080 |
There was a problem hiding this comment.
The containerPort has changed in each file but the targetPort for each associated Service has not been updated. Does the targetPort need to be updated in each file?
There was a problem hiding this comment.
Thanks, Eoin. I have updated the service targetPort in the second commit.
Signed-off-by: Yuanlin Xu <[email protected]>
|
/test integ-servicemesh-multicluster-2-6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since httpbin released 0.2.0, all httpbin samples on openshift are broken.
See [this issue in the httpbin repo|https://github.com/Kong/httpbin/issues/60]. The istio fix for this doesn't work on openshift but istio has moved to a go based httpbin instead of the python/pipenv version which works without any additional arguments or env var settings.