Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic PR to nightly from 2024-08-19T12:28:50Z #6027

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Automatic PR to nightly from 2024-08-19T12:28:50Z #6027

merged 3 commits into from
Aug 20, 2024

Conversation

milkmaker
Copy link
Collaborator

@milkmaker milkmaker commented Aug 19, 2024 •
edited
Loading

📁 Modified files

data/conf/rspamd/meta_exporter/pipe.php | 2 +-
data/conf/rspamd/meta_exporter/pushover.php | 2 +-
generate_config.sh | 14 +-
update.sh | 292 ++++++++++++++--------------
4 files changed, 155 insertions(+), 155 deletions(-)

@h3ssan
Fix: bash variables are not quoted (#6022)
3d62869 
* Fix: Double quote variables to prevent word splitting

* Fix `update.sh`: Double quote to prevent word splitting

* Refactor: Remove unnecessary white-spaces.
@milkmaker milkmaker requested a review from DerLinkman August 19, 2024 13:48
@milkmaker
Copy link
Collaborator Author

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@h3ssan
Replace weird character to the correct ' (#6029)
f9a7712 
* Replace weird character to the correct `'`

* Replace final weird character, just found.
@milkmaker
Copy link
Collaborator Author

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@bluewalk
Pushover/Quarantine utf 8 fix - fixes #6028 (#6031)
567ebbc 
* Decode rspamd-subject for pushover notifications

Fixes #6028

* Apply iconv_mime_decode to the quarantine function as well
This might contain utf-8 encoded text as well

* Moved the iconv_mime_decode "fix" back to pipe.php
@milkmaker
Copy link
Collaborator Author

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@DerLinkman DerLinkman merged commit ffcd242 into nightly Aug 20, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerLinkman DerLinkman Awaiting requested review from DerLinkman

Assignees

@DerLinkman DerLinkman

Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milkmaker @DerLinkman @h3ssan @bluewalk