Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for voting off #114

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add script for voting off #114

wants to merge 5 commits into from

Conversation

joshuef
Copy link
Contributor

@joshuef joshuef commented Mar 14, 2023 •
edited
Loading

  • changes default node size
  • adds script to detect voted off nodes
  • changes default log levels:

oetyng
oetyng previously approved these changes Mar 15, 2023
View reviewed changes
Copy link

@oetyng oetyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one Q about the port.

up.sh
@@ -10,7 +10,7 @@ NODE_BIN_PATH=${3}
NODE_VERSION=${4}
CLIENT_COUNT=${5}
AUTO_APPROVE=${6}
OTLP_COLLECTOR_ENDPOINT=${7}
OTLP_COLLECTOR_ENDPOINT=${7:-"http://dev-testnet-infra-543e2a753f964a15.elb.eu-west-2.amazonaws.com:4317"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this port always used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oetyng oetyng oetyng left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuef @oetyng