feat: make chunk size user defined #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEAKING CHANGE: all APIs updated to have min/max_encryptrable bytes passed in by the user. This allows for varying the use of the lib.
maqi
reviewed
Oct 15, 2024
| @@ -411,16 +407,21 @@ pub fn decrypt_from_chunk_files( | |||
| /// Encrypts a set of bytes and returns the encrypted data together with | |||
| /// the data map that is derived from the input data, and is used to later decrypt the encrypted data. | |||
| /// Returns an error if the size is too small for self-encryption. | |||
| /// Only files larger than 3072 bytes (3 * MIN_CHUNK_SIZE) can be self-encrypted. | |||
| /// Only files larger than 3072 bytes (3 * min_chunk_size) can be self-encrypted. | |||
There was a problem hiding this comment.
the number of 3072 shall be changed (same to the other place)
| @@ -51,6 +51,11 @@ use std::time::Duration; | |||
| // https://bheisler.github.io/criterion.rs/book/analysis.html#measurement | |||
| const SAMPLE_SIZE: usize = 20; | |||
|
|
|||
| /// The maximum size (before compression) of an individual chunk of a file, defined as 1024kiB. | |||
| const MAX_CHUNK_SIZE: usize = 1024 * 1024; | |||
There was a problem hiding this comment.
better make these two as consts for test usage only ?
as I see they got used in couple of testing places
| pos: usize, | ||
| len: usize, | ||
| max_chunk_size: usize, | ||
| ) -> (usize, usize) { | ||
| // FIX THIS SHOULD NOT BE ALLOWED | ||
| if file_size < (3 * MIN_CHUNK_SIZE) || pos >= file_size || len == 0 { |
There was a problem hiding this comment.
there shall no longer be a const of MIN_CHUNK_SIZE in production code anymore ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEAKING CHANGE: all APIs updated to have min/max_encryptrable bytes passed in by the user.
This allows for varying the use of the lib.