Fix ADC values reading & made different Arduino platforms compatible #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ADC values were summing inside uint8_t variable and overflowing. Added explicit type conversion to uint32_t 2. Wire lib for some platfroms (arduino nano e.g.) don`t have begin(sdaPin, sclPin) method. This coused compilation error. Removed BMP280::begin(int sdaPin, int sclPin) method 3. In _debugSerial mode in some statements variable p was changed to P as p do not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint8_tvariable and overflowing. Added explicit type conversion touint32_tbegin(sdaPin, sclPin)method. This caused compilation error. RemovedBMP280::begin(int sdaPin, int sclPin)method_debugSerialmode in some statements variable p was changed to P as p do not exist