Use custom header to find target cluster #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of using path parameter, which can confuse users, use a custom header that will be read by LB and then redirect the query to correct backend. This should work for most of the datasources as we can always add custom headers in Grafana. This will also avoid having to manipulate path manually after stripping path parameter. * Update tests and docs accordingly. * Add note in docs that it is possible to find target cluster using query labels and show how to do it. Signed-off-by: Mahendra Paipuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using path parameter, which can confuse users, use a custom header that will be read by LB and then redirect the query to correct backend. This should work for most of the datasources as we can always add custom headers in Grafana. This will also avoid having to manipulate path manually after stripping path parameter.
Update tests and docs accordingly.
Add note in docs that it is possible to find target cluster using query labels and show how to do it.