Refactor emissions pkg #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mahendrapaipuri
commented
Dec 24, 2023
mahendrapaipuri
commented
- Make pkg more modular and extensible
- Add Electricity Maps data source
- Export all available emission factors
- Add tests
* New implementation is more modular and extensible * Each emission source is split into separate file and register themselves into factory * In main file, we loop over factories and get emission factories from diff sources * Added new electicity maps source * OWID data is included in pkg as JSON file * Countries data is included in pkg to convert to and from from ISO 2 to ISO 3 * Added tests for each source Signed-off-by: Mahendra Paipuri <[email protected]>
* Simplified collector as most of the logic is in emissions pkg now Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
mahendrapaipuri
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.