Misc improvements #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahendra Paipuri <[email protected]>
* Add tests using fake procfs * Rename CLI opts to be more intuitive * Update test data files accordingly Signed-off-by: Mahendra Paipuri <[email protected]>
* jobidraw will show real job id for array jobs * Improve wording on CLI help Signed-off-by: Mahendra Paipuri <[email protected]>
* Users can simply use sudo in command cli option. CLI flag is redundant Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* batchjob_stats_server is more appropriate than stats_api Signed-off-by: Mahendra Paipuri <[email protected]>
* Formatted with golines -w --max-len=120 . Signed-off-by: Mahendra Paipuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/procfs in go routines to improve perfjobidrawinsacctinstead ofjobid. This is useful for array jobs to properly identify correct job IDrun.with.sudoflag for IPMI collector. Redundant.batchjob_stats_apitobatchjob_stats_server