chore: Improve error logging for sub collectors

Signed-off-by: Mahendra Paipuri <[email protected]>

pkg/collector/ebpf.go

@@ -512,13 +512,13 @@ func NewEbpfCollector(logger log.Logger, cgManager *cgroupManager) (*ebpfCollect
 func (c *ebpfCollector) Update(ch chan<- prometheus.Metric, cgroupIDUUIDMap map[string]string) error {
 	// Fetch all active cgroups
 	if err := c.discoverCgroups(cgroupIDUUIDMap); err != nil {
-		return err
+		return fmt.Errorf("failed to discover cgroups: %w", err)
 	}
 
 	// Fetch metrics from maps
 	aggMetrics, err := c.readMaps()
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to read bpf maps: %w", err)
 	}
 
 	// Start wait group
@@ -827,10 +827,12 @@ func (c *ebpfCollector) readMaps() (*aggMetrics, error) {
 	if securityCtx, ok := c.securityContexts[ebpfReadBPFMapsCtx]; ok {
 		if err := securityCtx.Exec(dataPtr); err == nil {
 			return dataPtr.aggMetrics, nil
+		} else {
+			return nil, err
 		}
 	}
 
-	return nil, ErrNoData
+	return nil, security.ErrNoSecurityCtx
 }
 
 // discoverCgroups walks through cgroup file system and discover all relevant cgroups based

pkg/collector/perf.go

@@ -543,7 +543,7 @@ func (c *perfCollector) Update(ch chan<- prometheus.Metric, cgroupIDUUIDMap map[
 	// Discover new processes
 	cgroups, err := c.discoverProcess()
 	if err != nil {
-		return fmt.Errorf("%w: %w", ErrNoData, err)
+		return fmt.Errorf("failed to discover processes: %w", err)
 	}
 
 	// Start new profilers for new processes
@@ -557,7 +557,7 @@ func (c *perfCollector) Update(ch chan<- prometheus.Metric, cgroupIDUUIDMap map[
 
 	// Ensure cgroups is non empty
 	if len(cgroups) == 0 {
-		return ErrNoData
+		return nil
 	}
 
 	// Start a wait group

pkg/collector/slurm.go

@@ -267,7 +267,7 @@ func (c *slurmCollector) Update(ch chan<- prometheus.Metric) error {
 	// Discover all active cgroups
 	metrics, err := c.discoverCgroups()
 	if err != nil {
-		return fmt.Errorf("%w: %w", ErrNoData, err)
+		return fmt.Errorf("failed to discover cgroups: %w", err)
 	}
 
 	// Start a wait group