Pass docker hub credentials from env

Signed-off-by: Mahendra Paipuri <[email protected]>
mahendrapaipuri · Apr 21, 2024 · 92c3b12 · 92c3b12
1 parent fcc9b01
commit 92c3b12
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,12 +11,12 @@ on:
         description: Quay.io organization
         default: mahendrapaipuri
   push:
-    # paths:
-    #   - "go.sum"
-    #   - "go.mod"
-    #   - "**.go"
-    #   - ".github/workflows/**"
-    #   - ".golangci.yml"
+    paths:
+      - "go.sum"
+      - "go.mod"
+      - "**.go"
+      - ".github/workflows/**"
+      - ".golangci.yml"
     branches: [main]
   pull_request:
     branches: [main]
@@ -59,8 +59,6 @@ jobs:
     with:
       registry: "docker.io"
       organization: ${{ inputs.docker_hub_organization }}
-      login: ${{ secrets.DOCKER_HUB_LOGIN }}
-      password: ${{ secrets.DOCKER_HUB_PASSWORD }}
 
   # quay:
   #   needs: [build]

diff --git a/.github/workflows/step_docker.yml b/.github/workflows/step_docker.yml
@@ -48,7 +48,10 @@ jobs:
       - name: Publish image for main branch
         if: github.ref == 'refs/heads/main'
         run: |
-          echo ${{ inputs.password }} | docker login -u ${{ inputs.login }} --password-stdin ${{ inputs.registry }}
+          echo ${DOCKER_HUB_PASSWORD} | docker login -u ${DOCKER_HUB_LOGIN} --password-stdin ${{ inputs.registry }}
           make docker-publish DOCKER_REPO=${{ inputs.registry }}/${{ inputs.organization }}
           make docker-manifest DOCKER_REPO=${{ inputs.registry }}/${{ inputs.organization }}
         shell: bash
+        env:
+          DOCKER_HUB_LOGIN: ${{ secrets.DOCKER_HUB_LOGIN }}
+          DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD }}