Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sbindir to point /usr/sbin (#76) #83

Closed
wants to merge 1 commit into from
Closed

Fix sbindir to point /usr/sbin (#76) #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Common prefixes for installation directories.
# See: https://www.gnu.org/software/make/manual/make.html
prefix = /usr/local
prefix = /usr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at 16.5 Variables for Installation Directories under the link above you see that the default should be /usr/local/. Since the GNU defaults are so widespread it's kind of what one expects as well, meaning that any deviation ends up surprising to end users.

Would your issue be solved if #72 was merged?

exec_prefix = $(prefix)
sbindir = $(exec_prefix)/sbin
libdir = $(exec_prefix)/lib
Expand All @@ -9,7 +9,7 @@ sysconfdir=/etc

wondershaper:
exit;

install:
install -Dm755 wondershaper $(sbindir)/wondershaper;
install -Dm644 wondershaper.service $(libdir)/systemd/system/wondershaper.service;
Expand Down