-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-13325 Issue#39347 grouped product qty validation issue fix #39377
base: 2.4-develop
Are you sure you want to change the base?
AC-13325 Issue#39347 grouped product qty validation issue fix #39377
Conversation
Hi @Mohamed-Asar. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run Static Tests, Functional Tests B2B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Mohamed-Asar,
Thanks for your contribution!
It seems the issue has been fixed already. We request you to please look into this #39347 (comment).
Thanks
Hello @engcom-Hotel , No, Still the issue exists on the latest 2.4-develop, i verified in my local env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Mohamed-Asar,
Thanks for the contribution!
Please cover the PR changes with some automated tests in accordance with DOD and also please fix the build failures.
Thanks
@engcom-Hotel Do i need to add MFTF ? or Jasmine test case ? and also i don't know see any build failure related to this PR, could you please let me know, what are the build failure regarding this PR ? |
Hello @Mohamed-Asar, I would suggest you add an MFTF to verify the code changes. for build failures lets try to re-run the tests, they might be flaky. Thanks |
@magento run all tests |
Description (*)
Fix for Grouped Product Quantity Validation Displays Errors for All Inputs When One Input Is Invalid
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)