MC-34540: Invisible reCaptcha newsletter failure "Incorrect ReCaptcha… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are no automated tests for msp_recaptcha, the project is unsupported and archived, we can use this local team branch PR for CR.
Fix Summary: method isZoneEnabled() was checking if ReCaptcha for the particular zone (the area where it should be applied) was enabled on a global scope, and in the case of our bug - it was. However, it was disabled on the particular website scope and for that website, the ReCaptcha score evaluation code wasn't placed, but the score was expected for validation.