Acsd 47527 #170
Open
Acsd 47527 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter placing order. - Merged MDVA-33068
…ter placing order. - Merged ACSD-47026
robertorubino
requested changes
Oct 13, 2022
| use Magento\InventoryMultiDimensionalIndexerApi\Model\IndexNameResolverInterface; | ||
| use Magento\InventoryIndexer\Indexer\IndexStructure; | ||
| use Magento\InventoryIndexer\Indexer\InventoryIndexer; | ||
| use Magento\InventoryIndexer\Indexer\SelectBuilderInterface; |
There was a problem hiding this comment.
This is already included at row 20
| use Magento\Framework\EntityManager\MetadataPool; | ||
| use Magento\InventoryCatalogApi\Api\DefaultStockProviderInterface; | ||
| use Magento\InventoryIndexer\Indexer\IndexStructure; | ||
| use Magento\InventoryIndexer\Indexer\InventoryIndexer; |
There was a problem hiding this comment.
See https://github.com/magento-sparta/inventory/pull/168/files#diff-46d1eab5b946d8db6bc8da2f9f205df1b929013e6df65c0edd95b1af0f44de3bL16: you are missing the part that remove some "use".. because of this, some "use" is included twice:
- use Magento\InventoryIndexer\Indexer\IndexStructure;
- use Magento\InventoryIndexer\Indexer\InventoryIndexer;
- use Magento\Framework\EntityManager\MetadataPool;
- use Magento\Catalog\Api\Data\ProductInterface;
…ter placing order. - Updated SelectBuilder.php according to review comments
robertorubino
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)