Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement basic sqli service #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

implement basic sqli service #1

wants to merge 4 commits into from

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Feb 24, 2022

No description provided.

@i4ki i4ki requested a review from katcipis February 24, 2022 14:49
Copy link
Member

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff man, sorry for the late review 🚀

DOCKER_DBPORT=3306
DOCKER_DBADDR=$(DOCKER_DBHOST):$(DOCKER_DBPORT)

ASROOT=sudo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be very curious if we can't make this work with podman 100% sudoless, this sudo stuff/sudo group shit on docker always annoyed me x_x. But unrelated to the PR, just sharing etc.

Comment on lines +6 to +20
# help

```
$ make help
usage: make [target] ...

targets:
db: Start db
dbcli: connects and retrieves a database a shell.
dbtest: test db connectivity
build: build sqli
up: build, setup db and start sqli service.
run: run
help: Show this help message.
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# help
```
$ make help
usage: make [target] ...
targets:
db: Start db
dbcli: connects and retrieves a database a shell.
dbtest: test db connectivity
build: build sqli
up: build, setup db and start sqli service.
run: run
help: Show this help message.
```
# help
Just run `make help`.

Rationale: Copying the help here will only make the docs eventually outdated.

func writeBanner(w http.ResponseWriter) {
fmt.Fprintf(w,
`+------------------------------------------------------------------------------+
| madlambda news network |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 🚀


INSERT INTO users (user,pass) VALUES
("admin", "very-secret-pass"),
("i4k", "****************"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("i4k", "****************"),
("i4k", "i love ken thompson"),

😆

(
"Russia retreats from crypto ban as it pushes rules for industry",
"Russias Ministry of Finance is planning to regulate cryptocurrencies in the country, despite earlier calls by the central bank for a ban on crypto."
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants