Nix 2.19 compatibility: remove leading dot from local file pnp.loader.mjs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaskorz
changed the title
|
This seems not to be necessary anymore: NixOS/nix#9867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Starting with Nix 2.19 (released November 2023), leading dots are not allowed in store paths anymore. While @edef1c stated in her PR that "it's unlikely anyone is relying on the current lax behaviour", I guess it has been overlooked that this also makes it impossible to use the path syntax with dotfiles (here:
${./.pnp.loader.mjs}).