Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple ports: fix libsoup dependency #27293

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

mohd-akram
Copy link
Member

Description

Type(s)
  • bugfix
Tested on

macOS 15.2 24C101 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@dbevans for port telepathy-gabble, telepathy-salut, gvfs, frogr, geocode-glib, gfbgraph, grilo, libchamplain, libgdata, libsocialweb, rest, uhttpmock, osm-gps-map-gtk2, libgrss, libgweather.
@barracuda156 for port tracker3.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jan 4, 2025
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this still a "path-style" dependency? Is there any other port that would provide the libsoup-2.4.pc file; if not it probably could/should just be a "port-style" dependency declaration.

@mohd-akram
Copy link
Member Author

@reneeotten Good point, updated.

@mohd-akram mohd-akram force-pushed the libsoup branch 3 times, most recently from d25e4f5 to f9e2b66 Compare January 4, 2025 17:41
@mohd-akram mohd-akram merged commit 468dc6f into macports:master Jan 4, 2025
0 of 3 checks passed
@mohd-akram mohd-akram deleted the libsoup branch January 4, 2025 19:22
@mascguy
Copy link
Member

mascguy commented Jan 5, 2025

Just curious, why didn't you reference the ticket you created, in the commit message?

@mohd-akram
Copy link
Member Author

@mascguy I created the ticket after I opened this PR for the remaining ports.

@mascguy
Copy link
Member

mascguy commented Jan 5, 2025

@mascguy I created the ticket after I opened this PR for the remaining ports.

Ah gotcha, no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

5 participants